Re: [PATCHv2 net-next] add DOVE extensions for VXLAN
From: David Miller <davem@davemloft.net>
Date: 2012-11-19 23:55:14
From: David L Stevens <redacted> Date: Thu, 15 Nov 2012 08:46:27 -0500
quoted hunk ↗ jump to hunk
@@ -111,6 +113,10 @@ struct vxlan_dev { __u8 tos; /* TOS override */ __u8 ttl; bool learn; + bool proxy; /* ARP reduction */ + bool rsc; /* route short-circuit */ + bool l2miss; /* L2 miss notifications */ + bool l3miss; /* L3 miss notifications */ unsigned long age_interval; struct timer_list age_timer;
Perhaps we've accumulated enough boolean states that a "u32 flags" are in order?
+ for (i=0; i<ETH_ALEN; ++i) + send_eth |= !!fdb->eth_addr[i];
Please use is_zero_ether_addr(). Otherwise these changes look fine to me, thanks.