On Sat, 2012-11-17 at 00:32 +0000, Ben Hutchings wrote:

On Fri, 2012-11-16 at 16:16 -0800, Eric Dumazet wrote:

quoted

On Sat, 2012-11-17 at 00:00 +0000, Ben Hutchings wrote:

quoted

I'm not sure what you mean by this.  Is your point that the
copy-on-write is never needed?  It is still possible for pskb_may_pull()
to fail.

A packet sniffer should have a copy of bad frames, even if dropped later
in our stacks.

GRO layer is not allowed to drop a frame, even if not 'correct'.

What do you think the accelerated hardware does with frames that have a
truncated VLAN tag?

The hardware should send us the frame, exactly like when RX checksum is
wrong.