Thread (23 messages) flat view 23 messages, 5 authors, 2012-11-16

Re: [RFC PATCH 13/13] ipv6: Pull IPv6 GSO registration out of the module

From: Ben Hutchings <hidden>
Date: 2012-11-16 22:04:17

On Tue, 2012-11-13 at 20:24 -0500, Vlad Yasevich wrote:
Sing GSO support is now separate, pull it out of the module
Sing?  Can we dance, too?
and make it its own init call.
Remove the cleanup functions as they are no longer called.
[...]
quoted hunk ↗ jump to hunk
--- a/include/net/protocol.h
+++ b/include/net/protocol.h
@@ -25,6 +25,7 @@
 #define _PROTOCOL_H
 
 #include <linux/in6.h>
+#include <linux/skbuff.h>
 #if IS_ENABLED(CONFIG_IPV6)
 #include <linux/ipv6.h>
 #endif
@@ -59,8 +60,6 @@ struct inet6_protocol {
 
 #define INET6_PROTO_NOPOLICY	0x1
 #define INET6_PROTO_FINAL	0x2
-/* This should be set for any extension header which is compatible with GSO. */
-#define INET6_PROTO_GSO_EXTHDR	0x4
 #endif
 
 struct net_offload {
@@ -72,6 +71,8 @@ struct net_offload {
 	int			(*gro_complete)(struct sk_buff *skb);
 	unsigned int		flags;	/* Flags used by IPv6 for now */
 };
+/* This should be set for any extension header which is compatible with GSO. */
+#define INET6_PROTO_GSO_EXTHDR	0x1
[...]

Should be renamed to INET6_OFFLOAD_GSO_EXTHDR, matching the new
structure name.

Ben.

-- 
Ben Hutchings, Staff Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help