Re: [PATCH 3/3] netfilter: ipv6: add getsockopt to retrieve origdst

On Tue, Nov 13, 2012 at 09:59:30AM +0100, Florian Westphal wrote:

YOSHIFUJI Hideaki [off-list ref] wrote:

quoted

pablo@netfilter.org wrote:

quoted

From: Florian Westphal <fw@strlen.de>
+	sin6.sin6_scope_id = sk->sk_bound_dev_if;
+
+	nf_ct_put(ct);
+	return copy_to_user(user, &sin6, sizeof(sin6)) ? -EFAULT : 0;
+}
+

I think we should set sin6_scope_id to sk->sk_bound_dev_if only if the
destination is link-local address.

Right, I see that getpeer/sockname has this test.

Dave, please either apply the patch as is (I'd submit a fixup)
or discard i, I'll then send a V2 with added
ipv6_addr_type(&sin->sin6_addr) & IPV6_ADDR_LINKLOCAL
test to Pablo.

Please, send me a follow-up patch, I'll apply and request a new pull
request.

Thanks.