[PATCH] ipv4: avoid undefined behavior in do_ip_setsockopt() · Xi Wang <xi.wang@gmail.com> · 2012-11-11
Re: [PATCH] ipv4: avoid undefined behavior in do_ip_setsockopt() · David Miller <davem@davemloft.net> · 2012-11-11
Re: [PATCH] ipv4: avoid undefined behavior in do_ip_setsockopt() · Xi Wang <xi.wang@gmail.com> · 2012-11-11
Re: [PATCH] ipv4: avoid undefined behavior in do_ip_setsockopt() · David Miller <davem@davemloft.net> · 2012-11-11
RE: [PATCH] ipv4: avoid undefined behavior in do_ip_setsockopt() · David Laight <hidden> · 2012-11-12
Re: [PATCH] ipv4: avoid undefined behavior in do_ip_setsockopt() · Xi Wang <xi.wang@gmail.com> · 2012-11-12

Re: [PATCH] ipv4: avoid undefined behavior in do_ip_setsockopt()

From: David Miller <davem@davemloft.net>
Date: 2012-11-11 22:51:34

From: Xi Wang <xi.wang@gmail.com>
Date: Sun, 11 Nov 2012 17:18:55 -0500

On 11/11/12 5:02 PM, David Miller wrote:

quoted

This code is a fast bit test on purpose.  You're making the
code slower.

No, it's the opposite.  All modern compilers optimize switch cases
into a fast bit test.

Indeed, I even checked sparc64 with gcc-4.6 and it looks good.

Thanks for the clarification, I'll apply this, thanks.