Thread (4 messages) flat view 4 messages, 4 authors, 2012-11-09

Re: [PATCH] gianfar: ethernet vanishes after restoring from hibernation

From: David Miller <davem@davemloft.net>
Date: 2012-11-09 22:09:01

From: Paul Gortmaker <redacted>
Date: Fri,  9 Nov 2012 09:43:51 -0500
From: Wang Dongsheng <redacted>

If a gianfar ethernet device is down prior to hibernating a
system, it will no longer be present upon system restore.

For example:

	~# ifconfig eth0 down
	~# echo disk > /sys/power/state

	  <trigger a restore from hibernation>

	~# ifconfig eth0 up
	SIOCSIFFLAGS: No such device

This happens because the restore function bails out early upon
finding devices that were not up at hibernation.  In doing so,
it never gets to the netif_device_attach call at the end of
the restore function.  Adding the netif_device_attach as done
here also makes the gfar_restore code consistent with what is
done in the gfar_resume code.

Cc: Claudiu Manoil <redacted>
Signed-off-by: Wang Dongsheng <redacted>
Signed-off-by: Paul Gortmaker <redacted>
Applied, thanks.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help