Thread (1 message) 1 message, 1 author, 2012-11-09

Re: [PATCH v4 3/5] usbnet: smsc95xx: fix memory leak in smsc95xx_suspend

From: David Miller <hidden>
Date: 2012-11-09 07:25:20

From: Maulik Mankad <redacted>
Date: Fri, 9 Nov 2012 12:28:17 +0530
We don't need memset() here.
May be command[2] = {0}; offset[2] = {0}; crc[4] = {0}; is enough.
The compiler can see this an will eliminate the unnecessary
clears.

So it's better to use memset and make the code much clearer
and easier to audit.
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help