Re: [PATCH] ethtool: Support et131x registers in -d
From: Ben Hutchings <hidden>
Date: 2012-11-08 19:26:00
On Tue, 2012-10-30 at 21:57 +0000, Mark Einon wrote:
The et131x register set contains useful details of RX/TX queues for the device. This dumps them with the -d option. Signed-off-by: Mark Einon <mark.einon@gmail.com>
Applied, thanks. However: [...]
quoted hunk ↗ jump to hunk
--- /dev/null +++ b/et131x.c@@ -0,0 +1,120 @@ +#include <stdio.h> +#include <string.h> +#include "internal.h" + +int et131x_dump_regs(struct ethtool_drvinfo *info, struct ethtool_regs *regs) +{ + u32 *reg = (u32 *)regs->data; + + fprintf(stdout, "PHY Registers\n");
[...] In case you need to change the dump format later, it might be worth adding a version check here. But if you're confident that you'll only ever append to the dump format, this should be fine for now. Ben. -- Ben Hutchings, Staff Engineer, Solarflare Not speaking for my employer; that's the marketing department's job. They asked us to note that Solarflare product names are trademarked.