Re: [PATCH v3 3/5] usbnet: smsc95xx: fix memory leak in smsc95xx_suspend

On Tue, Nov 6, 2012 at 9:20 PM, Steve Glendinning [off-list ref] wrote:

On 6 November 2012 01:45, Ming Lei [off-list ref] wrote:

quoted

This patch fixes memory leak in smsc95xx_suspend.

Good spot, thanks!

Note that check_warn_return just above your kfree can cause early
return in the error case, which would still leak filter_mask, so we
might want to explicitly expand that instance of the helper macro.

OK, will update the patch.

BTW, I just saw the smsc95xx datasheet and the vendor's driver
source code, and found the chip supports runtime PM well
(remote wakeup on 'good packet' or link change), so do you
plan to implement that?

Thanks,
--
Ming Lei