Re: [PATCH net-next] htb: fix two bugs

On Mon, 2012-11-05 at 13:06 -0800, Eric Dumazet wrote:

From: Eric Dumazet <edumazet@google.com>

Commit 56b765b79e9 (htb: improved accuracy at high rates)
introduced two bugs :

1) one bstats_update() was inadvertently removed from
   htb_dequeue_tree(), breaking statistics/rate estimation.

2) Missing qdisc_put_rtab() calls in htb_change_class(),
   leaking kernel memory, now struct htb_class no longer
   retains pointers to qdisc_rate_table structs.

   Since only rate is used, dont use qdisc_get_rtab() calls
   copying data we ignore anyway.

Signed-off-by: Eric Dumazet <edumazet@google.com>
Cc: Vimalkumar <redacted>
---

Please hold on this patch, I'll add a check in V2 :

We should make sure rates are not zero (check is done in
qdisc_get_rtab())