(off-list ancestor, not in this archive)
[net-next:master 122/152] drivers/ptp/ptp_chardev.c:36 ptp_ioctl() warn: 'sysoff' puts 832 bytes on stack · Yuanhan Liu <hidden> · 2012-11-02
Re: [net-next:master 122/152] drivers/ptp/ptp_chardev.c:36 ptp_ioctl() warn: 'sysoff' puts 832 bytes on stack · Richard Cochran <richardcochran@gmail.com> · 2012-11-02
Re: [net-next:master 122/152] drivers/ptp/ptp_chardev.c:36 ptp_ioctl() warn: 'sysoff' puts 832 bytes on stack · David Miller <davem@davemloft.net> · 2012-11-03
Re: [net-next:master 122/152] drivers/ptp/ptp_chardev.c:36 ptp_ioctl() warn: 'sysoff' puts 832 bytes on stack · Richard Cochran <richardcochran@gmail.com> · 2012-11-03
Re: [net-next:master 122/152] drivers/ptp/ptp_chardev.c:36 ptp_ioctl() warn: 'sysoff' puts 832 bytes on stack · David Miller <davem@davemloft.net> · 2012-11-03
[PATCH net-next 1/2] ptp: reduce stack usage when reading external time stamps · Richard Cochran <richardcochran@gmail.com> · 2012-11-26
Re: [PATCH net-next 1/2] ptp: reduce stack usage when reading external time stamps · David Miller <davem@davemloft.net> · 2012-11-26
[PATCH net-next 2/2] ptp: reduce stack usage when measuring the system time offset · Richard Cochran <richardcochran@gmail.com> · 2012-11-26
Re: [PATCH net-next 2/2] ptp: reduce stack usage when measuring the system time offset · David Miller <davem@davemloft.net> · 2012-11-26

Re: [net-next:master 122/152] drivers/ptp/ptp_chardev.c:36 ptp_ioctl() warn: 'sysoff' puts 832 bytes on stack

From: Richard Cochran <richardcochran@gmail.com>
Date: 2012-11-02 08:59:24

On Fri, Nov 02, 2012 at 10:06:31AM +0800, Yuanhan Liu wrote:

Hi Richard,

_just_ FYI and let you aware of it, there are new smatch warnings show up in

tree:   git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git master
head:   b77bc2069d1e437d5a1a71bb5cfcf4556ee40015
commit: 215b13dd288c2e1e4461c1530a801f5f83e8cd90 [122/152] ptp: add an ioctl to compare PHC time with system time

+ drivers/ptp/ptp_chardev.c:36 ptp_ioctl() warn: 'sysoff' puts 832 bytes on stack
  drivers/ptp/ptp_chardev.c:144 ptp_read() warn: 'event' puts 960 bytes on stack

I am aware that these methods use large stack buffers, but I thought
it was okay seeing as they are both under the 1k limit.

Thanks,
Richard

`h`	back out one level
`j`	next message in thread
`k`	previous message in thread
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help