Thread (1 message) 1 message, 1 author, 2012-10-30

Re: [PATCH 1/4] net: davinci_mdio: Fix typo mistake in calling runtime-pm api

DORMANTno replies REVIEWED: 1 (1M)

From: Peter Korsgaard <jacmet@sunsite.dk>
Date: 2012-10-30 21:33:53
Also in: linux-arm-kernel, linux-omap

1 review trailer.

quoted
quoted
quoted
quoted
"Vaibhav" == Vaibhav Hiremath [off-list ref] writes:
 Vaibhav> By mistake (most likely a copy-paste), instead of pm_runtime_get_sync()
 Vaibhav> api, driver is calling pm_runtime_put_sync() api in resume callback
 Vaibhav> function. The bug was introduced by commit id (ae2c07aaf74:
 Vaibhav> davinci_mdio: runtime PM support).

 Vaibhav> Now, the reason why it didn't impact functionality is, the patch has
 Vaibhav> been tested on AM335x-EVM and BeagleBone platform while submitting;
 Vaibhav> and in case of AM335x the MDIO driver doesn't control the module
 Vaibhav> enable/disable part, which is handled by CPSW driver.

 Vaibhav> Signed-off-by: Vaibhav Hiremath [off-list ref]
 Vaibhav> Cc: Mugunthan V N [off-list ref]
 Vaibhav> Cc: Richard Cochran [off-list ref]

Acked-by: Peter Korsgaard <jacmet@sunsite.dk>

-- 
Bye, Peter Korsgaard
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help