[PATCH v4 00/10] net/macb: driver enhancement concerning GEM support, ring logic and cleanup · Nicolas Ferre <hidden> · 2012-10-31
[PATCH v4 01/10] net/macb: Add support for Gigabit Ethernet mode · Nicolas Ferre <hidden> · 2012-10-31
[PATCH v4 02/10] net/macb: memory barriers cleanup · Nicolas Ferre <hidden> · 2012-10-31
[PATCH v4 03/10] net/macb: change debugging messages · Nicolas Ferre <hidden> · 2012-10-31
[PATCH v4 04/10] net/macb: remove macb_get_drvinfo() · Nicolas Ferre <hidden> · 2012-10-31
[PATCH v4 07/10] net/macb: ethtool interface: add register dump feature · Nicolas Ferre <hidden> · 2012-10-31
[PATCH v4 09/10] net/macb: Offset first RX buffer by two bytes · Nicolas Ferre <hidden> · 2012-10-31
[PATCH v4 10/10] net/macb: add pinctrl consumer support · Nicolas Ferre <hidden> · 2012-10-31
[PATCH v4 08/10] net/macb: better manage tx errors · Nicolas Ferre <hidden> · 2012-10-31
[PATCH v4 06/10] net/macb: clean up ring buffer logic · Nicolas Ferre <hidden> · 2012-10-31
[PATCH v4 05/10] net/macb: tx status is more than 8 bits now · Nicolas Ferre <hidden> · 2012-10-31
Re: [PATCH v4 00/10] net/macb: driver enhancement concerning GEM support, ring logic and cleanup · Jean-Christophe PLAGNIOL-VILLARD <hidden> · 2012-11-01
Re: [PATCH v4 00/10] net/macb: driver enhancement concerning GEM support, ring logic and cleanup · David Miller <davem@davemloft.net> · 2012-11-01

[PATCH v4 05/10] net/macb: tx status is more than 8 bits now

STALE5093d REVIEWED: 1 (0M)

From: Nicolas Ferre <hidden>
Date: 2012-10-31 16:08:26
Also in: linux-arm-kernel, lkml
Subsystem: atmel macb ethernet driver, networking drivers, the rest · Maintainers: Théo Lebrun, Andrew Lunn, "David S. Miller", Eric Dumazet, Jakub Kicinski, Paolo Abeni, Linus Torvalds

Revision v4 of 4 in this series; 1 review trailer.

Revisions (4)

2012-09-05 v1 [diff vs current]
2012-09-19 v2 [diff vs current]
2012-10-30 v3 [diff vs current]
2012-10-31 v4 current

On some revision of GEM, TSR status register has more information.

Signed-off-by: Nicolas Ferre <redacted>
Tested-by: Joachim Eastwood <redacted>
---
 drivers/net/ethernet/cadence/macb.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/cadence/macb.c b/drivers/net/ethernet/cadence/macb.c
index 4db52f3..cd6d431 100644
--- a/drivers/net/ethernet/cadence/macb.c
+++ b/drivers/net/ethernet/cadence/macb.c

@@ -314,7 +314,7 @@ static void macb_tx(struct macb *bp)
 	status = macb_readl(bp, TSR);
 	macb_writel(bp, TSR, status);
 
-	netdev_vdbg(bp->dev, "macb_tx status = %02lx\n", (unsigned long)status);
+	netdev_vdbg(bp->dev, "macb_tx status = 0x%03lx\n", (unsigned long)status);
 
 	if (status & (MACB_BIT(UND) | MACB_BIT(TSR_RLE))) {
 		int i;

-- 
1.8.0

`h`	back out one level
`j`	next message in thread
`k`	previous message in thread
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help