Thread (6 messages) 6 messages, 4 authors, 2012-11-03

Re: [PATCH 1/2] drivers/net/ethernet/nxp/lpc_eth.c: Call mdiobus_unregister before mdiobus_free

flat view

From: Alexandre Pereira da Silva <hidden>
Date: 2012-10-29 11:58:14
Also in: kernel-janitors, lkml

On Sun, Oct 28, 2012 at 2:12 PM, Peter Senna Tschudin
[off-list ref] wrote:
Based on commit b27393aecf66199f5ddad37c302d3e0cfadbe6c0

Calling mdiobus_free without calling mdiobus_unregister causes
BUG_ON(). This patch fixes the issue.

The semantic patch that found this issue(http://coccinelle.lip6.fr/):
// <smpl>
@@
expression E;
@@
  ... when != mdiobus_unregister(E);

+ mdiobus_unregister(E);
  mdiobus_free(E);
// </smpl>

Signed-off-by: Peter Senna Tschudin <peter.senna@gmail.com>
---
Tested-by: Alexandre Pereira da Silva <redacted>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help