Re: [PATCH] vlan: set sysfs device_type to 'vlan'

On Tue, 2012-10-23 at 09:14 -0700, Ben Greear wrote:

On 10/22/2012 11:36 PM, David Miller wrote:

quoted

From: Doug Goldstein <redacted>
Date: Mon, 22 Oct 2012 00:53:57 -0500

quoted

Sets the sysfs device_type to 'vlan' for udev. This makes it easier for
applications that query network information via udev to identify vlans
instead of using strrchr().

Signed-off-by: Doug Goldstein <redacted>

You're extremely misguided.  This change, in fact, makes it ten times
harder for such applications to query such devices.

If the application doesn't care, it can use the old way (which at least
for me, involves string-comparing the driver name ethtool returns, which
sucks at best).

The 'old way' that has only worked since Linux 2.6.29 (3.5 years)?

The 'right way' seems to be to query for VLAN information through
netlink.  But that has only worked since Linux 2.6.23 (5 years ago).
The real 'old way' is to use SIOCGIFVLAN. :-/

And applications that care might suddenly have more features, or be more
efficient when running on newer kernels..

Ben.

-- 
Ben Hutchings, Staff Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.