Re: [PATCH v2 net-next 1/2] r8169: enable ALDPS for power saving
flat view
From: Francois Romieu <romieu@fr.zoreil.com>
Date: 2012-10-23 19:54:18
Also in:
lkml
Hayes Wang [off-list ref] :
Enable ALDPS function to save power when link down. Note that the feature should be set after the other PHY settings. And the firmware is necessary. Don't enable it without loading the firmware. Signed-off-by: Hayes Wang <redacted>
[...] Please see my just sent answer in yesterday's thread.
quoted hunk ↗ jump to hunk
+static void r810x_aldps_disable(struct rtl8169_private *tp) +{ + rtl_writephy(tp, 0x1f, 0x0000); + rtl_writephy(tp, 0x18, 0x0310); + msleep(100); +}
rtl8402_hw_phy_config used a msleep(20). Meguesses it won't hurt, right ? [...]
quoted hunk ↗ jump to hunk
+ + /* ALDPS enable */ + r8168_aldps_enable_1(tp);
The functions are literate enough: you can remove the comment. [...]
quoted hunk ↗ jump to hunk
@@ -6391,6 +6431,8 @@ static void rtl8169_net_suspend(struct net_device *dev) { struct rtl8169_private *tp = netdev_priv(dev); + tp->features &= ~RTL_FEATURE_EXTENDED; + if (!netif_running(dev)) return;
No (as previously stated). -- Ueimor