Re: [PATCH] SUNRPC: Prevent kernel stack corruption on long values of flush

On Wed, Oct 17, 2012 at 01:59:39PM -0400, Sasha Levin wrote:

On Wed, Jul 18, 2012 at 1:39 PM, J. Bruce Fields [off-list ref] wrote:

quoted

On Tue, Jul 17, 2012 at 12:01:26AM +0200, Sasha Levin wrote:

quoted

The buffer size in read_flush() is too small for the longest possible values
for it. This can lead to a kernel stack corruption:

Thanks!

I've just stumbled on this crash again, and noticed that this patch
never made it in.

Was it just a mixup, or is something still missing?

Oh, man, I guess I got distracted by the subsequent base10len()
discussion.

Added to my for-3.7 branch, I'll push that out after some tests and
hopefully send in a pull request tomorrow.

Thanks for noticing the ommission.

--b.
--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html