Re: [PATCH v6 04/10] ipc: add new SHM_SET command for sys_shmctl() call
From: Ben Hutchings <hidden>
Date: 2012-10-15 19:00:36
Also in:
lkml
On Mon, 2012-10-15 at 19:59 +0400, Stanislav Kinsbursky wrote:
New SHM_SET command will be interpreted exactly as IPC_SET, but also will update key, cuid and cgid values. IOW, it allows to change existent key value. The fact, that key is not used is checked before update. Otherwise -EEXIST is returned.
[...]
quoted hunk ↗ jump to hunk
--- a/ipc/shm.c +++ b/ipc/shm.c
[...]
quoted hunk ↗ jump to hunk
@@ -759,6 +763,10 @@ static int shmctl_down(struct ipc_namespace *ns, int shmid, int cmd, case IPC_RMID: do_shm_rmid(ns, ipcp); goto out_up; + case SHM_SET: + err = ipc_update_key(&shm_ids(ns), &shmid64.shm_perm, ipcp); + if (err) + break;
[...] Please add /* fall through */ here, and in the similar cases in patches 5 and 7, to make clear that it's deliberate. Ben. -- Ben Hutchings, Staff Engineer, Solarflare Not speaking for my employer; that's the marketing department's job. They asked us to note that Solarflare product names are trademarked.