Re: tg3 driver upgrade (Linux 2.6.32 -> 3.2) breaks IBM Bladecenter SoL

On Tue, 2012-10-02 at 14:07 +0200, Ferenc Wagner wrote:

I'm done with bisecting it: the first bad commit is:

commit dabc5c670d3f86d15ee4f42ab38ec5bd2682487d
Author: Matt Carlson [off-list ref]
Date:   Thu May 19 12:12:52 2011 +0000

    tg3: Move TSO_CAPABLE assignment
    
    This patch moves the code that asserts the TSO_CAPABLE flag closer
to
    where the TSO capabilities flags are set.  There isn't a good
enough
    reason for the code to be separated.
    
    Signed-off-by: Matt Carlson [off-list ref]
    Reviewed-by: Michael Chan [off-list ref]
    Signed-off-by: David S. Miller [off-list ref]

Thanks, I'll look into this.

On the other hand, losing the SoL console even temporarily during boot
(as it happens with a minimal kernel before this commit) isn't nice
either.  I'll try to look after that, too, just mentioning it here... 

This is expected as the driver has to reset the link and you'll lose SoL
for a few seconds until link comes back up.  We can look into an
enhancement to not touch the link if it is already in a good state when
the driver comes up.