Re: [BUG] TIPC handling of -ERESTARTSYS in connect()
From: Chris Friesen <hidden>
Date: 2012-10-31 23:01:39
From: Chris Friesen <hidden>
Date: 2012-10-31 23:01:39
On 09/04/2012 08:54 AM, Chris Friesen wrote:
On 09/02/2012 09:16 PM, Ying Xue wrote:quoted
quoted
quoted
It looks like the case where we come in with "sock->state == SS_LISTENING" has changed. Previously we would return -EOPNOTSUPP but now it'll be -EINVAL. Is that intentional?Just noticed something else. In the SS_CONNECTING case I don't think there's any point in setting "res = -EALREADY" since a bit further down it gets set unconditionally anyway.Yes, you are right. Please check v2 version.Looks good to me. Still haven't had a chance to actually test it though, we're pushing out a release and time is scarce.
I finally got a chance to test this out, and it does indeed fix the problem. Please push it upstream. Tested-by: Chris Friesen <redacted> Chris