RE: [net-next 02/12] ixgbe: Fix return value from macvlan filter function

-----Original Message-----
From: Konstantin Stepanyuk [mailto:konstantin.stepanyuk@gmail.com]
Sent: Saturday, October 27, 2012 11:37 AM
To: Kirsher, Jeffrey T
Cc: davem@davemloft.net; Rose, Gregory V; netdev@vger.kernel.org;
gospo@redhat.com; sassmann@redhat.com
Subject: Re: [net-next 02/12] ixgbe: Fix return value from macvlan filter
function

On Fri, Oct 26, 2012 at 6:08 PM, Jeff Kirsher
[off-list ref] wrote:

quoted

From: Greg Rose <redacted>

The function to set the macvlan filter should return success or
failure instead of the index of the filter.  The message processing
function was misinterpreting the index as a non-zero return code
indicating failure and NACKing MAC filter set messages that actually

succeeded.

quoted

Signed-off-by: Greg Rose <redacted>
Tested-by: Robert Garrett <redacted>
Signed-off-by: Jeff Kirsher <redacted>
---
 drivers/net/ethernet/intel/ixgbe/ixgbe_sriov.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_sriov.c

b/drivers/net/ethernet/intel/ixgbe/ixgbe_sriov.c
index 96876b7..b68bf0f 100644

--- a/drivers/net/ethernet/intel/ixgbe/ixgbe_sriov.c
+++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_sriov.c

@@ -742,7 +742,8 @@ static int ixgbe_set_vf_macvlan_msg(struct

ixgbe_adapter *adapter,

quoted

                e_warn(drv,
                       "VF %d has requested a MACVLAN filter but there

is no space for it\n",

quoted

                       vf);
-       return err;
+
+       return !!err < 0;

This expression always resolves to false, either 0 < 0 or 1 < 0, because
'!' has higher precedence than '<'.

It's a typo.  I'll fix it.

- Greg

Thanks,
Konstantin