Thread (5 messages) 5 messages, 4 authors, 2012-10-29

Re: [PATCH net-next] ipv6: remove useless test in dev_forward_change()

flat view

From: Nicolas Dichtel <hidden>
Date: 2012-10-29 10:07:43

Please ignore, the patch has already be sent by Cong Wang [off-list ref].

Le 29/10/2012 10:24, Nicolas Dichtel a écrit :
quoted hunk ↗ jump to hunk
idev->dev cannot be NULL.

Signed-off-by: Nicolas Dichtel <redacted>
---
  net/ipv6/addrconf.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/ipv6/addrconf.c b/net/ipv6/addrconf.c
index 8f0b12a..c9b1cf3 100644
--- a/net/ipv6/addrconf.c
+++ b/net/ipv6/addrconf.c
@@ -607,7 +607,7 @@ static void dev_forward_change(struct inet6_dev *idev)
  	dev = idev->dev;
  	if (idev->cnf.forwarding)
  		dev_disable_lro(dev);
-	if (dev && (dev->flags & IFF_MULTICAST)) {
+	if (dev->flags & IFF_MULTICAST) {
  		if (idev->cnf.forwarding)
  			ipv6_dev_mc_inc(dev, &in6addr_linklocal_allrouters);
  		else
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help