Re: [PATCH net-next 00/15] 6lowpan: Some more bug fixes

On 10/25/2012 10:49 AM, Tony Cheneau wrote:

 I'm not so OK with removing patch 15, or at least, it would require
some more testing in other parts of the code. Basically, the TBD are
placeholder for when the Association Request/Response will be
reimplemented. I introduced it because otherwise, .assoc_req and
.assoc_resp entries of mac802154_mlme_wpan would go uninitialized and
would cause kernel crash when called. I could have modified the
calling code to deal with that, but I thought these primitives were
meant to be re-implemented soon anyway.

I think just simply stating this in the commit message would fix the
issue here. Maybe something like "Fix crash where assoc_req() and
assoc_resp() were not defined."

This should probably get split into two patches, one for BSN and the
other for assoc.

Also, make the bsn functions static, and the convention is to put static
functions above where they are being used, so that you don't have to
forward declare them. It looks though, like this source file doesn't do
that for other functions, so maybe following the convention of this file
for now is ok.

Alan.


------------------------------------------------------------------------------
Everyone hates slow websites. So do we.
Make your web apps faster with AppDynamics
Download AppDynamics Lite for free today:
http://p.sf.net/sfu/appdyn_sfd2d_oct