Re: [PATCH net-next 05/15] 6lowpan: use short IEEE 802.15.4 addresses for broadcast destination
flat view
From: Jan Ceuleers <hidden>
Date: 2012-10-23 07:10:14
On 10/23/2012 06:09 AM, Tony Cheneau wrote:
quoted hunk ↗ jump to hunk
It is intended that the IEEE 802.15.4 standard uses the 0xFFFF short address (2 bytes) for message broadcasting. Signed-off-by: Tony Cheneau <redacted> --- net/ieee802154/6lowpan.c | 21 +++++++++++++-------- 1 files changed, 13 insertions(+), 8 deletions(-)diff --git a/net/ieee802154/6lowpan.c b/net/ieee802154/6lowpan.c index 49d91df..8a2ee95 100644 --- a/net/ieee802154/6lowpan.c +++ b/net/ieee802154/6lowpan.c@@ -577,21 +577,26 @@ static int lowpan_header_create(struct sk_buff *skb, * this isn't implemented in mainline yet, so currently we assign 0xff */ { + mac_cb(skb)->flags = IEEE802154_FC_TYPE_DATA; + /* prepare wpan address data */ sa.addr_type = IEEE802154_ADDR_LONG; sa.pan_id = 0xff; - - da.addr_type = IEEE802154_ADDR_LONG; - da.pan_id = 0xff; - - memcpy(&(da.hwaddr), daddr, 8); memcpy(&(sa.hwaddr), saddr, 8); - mac_cb(skb)->flags = IEEE802154_FC_TYPE_DATA; + da.pan_id = 0xff; + /* if the destination address is the broadcast address, + use short address */
David likes comments in the networking code to look /* Like * this */ Note that the comment is closed on a line by itself. There's an example at the top of this hunk.