Thread (17 messages) 17 messages, 3 authors, 2012-10-23

Re: [net-next 08/12] ixgbe: using is_zero_ether_addr() to simplify the code

flat view

From: Joe Perches <joe@perches.com>
Date: 2012-10-23 04:45:19

On Mon, 2012-10-22 at 21:26 -0700, Jeff Kirsher wrote:
From: Wei Yongjun <redacted>
Using is_zero_ether_addr() to simplify the code.
[]
quoted hunk ↗ jump to hunk
diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_common.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_common.c
[]
quoted hunk ↗ jump to hunk
@@ -1778,8 +1778,7 @@ s32 ixgbe_validate_mac_addr(u8 *mac_addr)
[]
quoted hunk ↗ jump to hunk
-	else if (mac_addr[0] == 0 && mac_addr[1] == 0 && mac_addr[2] == 0 &&
-	         mac_addr[3] == 0 && mac_addr[4] == 0 && mac_addr[5] == 0)
+	else if (is_zero_ether_addr(mac_addr))
This means the more comprehensive simplifying patch
I submitted doesn't apply.  Easy to fix up though.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help