Re: [PATCHv3] ipv6: Enable enough of the code to handle GSO when disabled.

On Wed, 2012-10-17 at 18:13 +0200, Eric Dumazet wrote:

On Wed, 2012-10-17 at 11:46 -0400, Vlad Yasevich wrote:

quoted

This patch attempts to solve this by enabling just enough code so GSO
is correctly processed.  However, I should point out that if IPv6 is
simply blacklisted or not built for the kernel, this problem will
still persist.

So I guess this should be done in a different way ?

We currently use a single structure (struct packet_type) to hold 
pointers to different methods. (The .func() field, and the gso/gro
stuff)

We probably need to split it in two parts, and make one part linked into
kernel, even if CONFIG_IPV6=n, so that GRO/GSO is fully IPv4/IPv6
functional.

[...]

Either that or make sure that we don't advertise IPv6 GSO when IPv6 is
disabled.

Ben.

-- 
Ben Hutchings, Staff Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.