Re: setting flow spec rules under vswitch configuration

On Wed, 2012-10-10 at 16:31 +0200, Or Gerlitz wrote:

On 10/10/2012 16:28, Ben Hutchings wrote:

quoted

On Wed, 2012-10-10 at 16:16 +0200, Or Gerlitz wrote:
[...]

quoted

quoted

Thanks for setting the sketch of a plan here... so if we go little bit
into details, we can safely move 20 bytes from the hadata[60] field into
the beginning of struct ethtool_flow_ext, which will still allow old
user space to work with newer kernels. As for newer uses space that
would like to set mac addresses within
ethtool_flow_ext, how are they supposed to identify if the kernel
supports this extension (of the extension...)?

Well they can't tell in advance, but we can define another flag in
flow_type like FLOW_EXT and existing drivers will reject flow specs with
that flag set.

I understand what we can add a flag which will be rejected by driver's 
that don't support this ext,
can the same/similar flag be used for newer user space code to mark they 
want this ext?

Exactly.

Ben.

-- 
Ben Hutchings, Staff Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.