Thread (15 messages) 15 messages, 6 authors, 2012-10-12

RE: [patch] isdn: fix a wrapping bug in isdn_ppp_ioctl()

flat view

From: David Laight <hidden>
Date: 2012-10-10 10:50:36
Also in: kernel-janitors

-		unsigned long protos[8] = {0,};
+		DECLARE_BITMAP(protos, BITS_PER_LONG * 8) = { 0, };
...
-		if ((r = set_arg(argp, protos, 8 * sizeof(long))))
+		if ((r = set_arg(argp, protos, sizeof(protos))))
That change makes a big assumption about the implementation
of DECLARE_BITMAP().
Unless it is guaranteed to be implemented as 'unsigned long[]'
then you've changed what the code might do.

	David
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help