Re: [PATCH 01/12] usbnet: introduce usbnet 3 command helpers

On Wed, Oct 10, 2012 at 11:19 AM, Ming Lei [off-list ref] wrote:

On Tue, Oct 9, 2012 at 4:47 PM, Oliver Neukum [off-list ref] wrote:

quoted

Using GFP_KERNEL you preclude using those in resume() and error handling.
Please pass a gfp_t parameter.

IMO, it is not a big deal because generally only several bytes are to be
allocated inside these helpers.

Also pm_restrict_gfp_mask()/pm_restore_gfp_mask() have been introduced
to address the problem for 2 years, looks the gfp_t isn't needed, doesn't it?

Thanks,
--
Ming Lei