Re: [net:master 6/7] mdio-gpio.c:(.text+0x58): multiple definition of `of_mdiobus_register'

On Wed, Oct 10, 2012 at 07:28:18AM +0800, Fengguang Wu wrote:

Hi Mark,

FYI, kernel build failed on

tree:   git://git.kernel.org/pub/scm/linux/kernel/git/davem/net.git master
head:   5175a5e76bbdf20a614fb47ce7a38f0f39e70226
commit: 4085a7f0a09c73ef3e9de113c9f04d78c79be645 [6/7] netdev/phy: Prototype of_mdio_find_bus()
config: i386-allyesconfig

All error/warnings:

drivers/net/phy/mdio-gpio.o: In function `of_mdiobus_register':
mdio-gpio.c:(.text+0x58): multiple definition of `of_mdiobus_register'
drivers/net/phy/libphy.o:(.text+0x23d7): first defined here
drivers/net/phy/mdio-gpio.o: In function `of_phy_find_device':

Hrm, I can't see how that would occur due to this patch unless
!CONFIG_OF is selected which I wouldn't expect from allyesconfig, the
!CONFIG_OF stubs in the header are buggy as they aren't static.  There
is a bug there, though - I'll send a patch for that.