Thread (6 messages) 6 messages, 3 authors, 2012-10-11

Re: [PATCH] net/ethernet/jme: disable ASPM

flat view

From: David Miller <davem@davemloft.net>
Date: 2012-10-08 19:24:29

From: Kevin Baradon <redacted>
Date: Mon,  8 Oct 2012 21:02:36 +0200
Based on patch from Matthew Garrett [off-list ref] (https://lkml.org/lkml/2011/11/11/168).

http://driveragent.com/archive/30421/7-0-14 indicates that ASPM is
disabled on the 250 and 260. Duplicate for sanity.

Fixes random RX engine hangs I experienced with JMC250 on Clevo W270HU.

Signed-off-by: Kevin Baradon <redacted>
This should be a PCI quirk shouldn't it?

Also:
+	pci_disable_link_state(pdev, PCIE_LINK_STATE_L0S | PCIE_LINK_STATE_L1 |
+		PCIE_LINK_STATE_CLKPM);
This is terrible formatting, you must line up the "PCIE_LINK_STATE_CLKPM" on
the second line with the very first column after the openning parenthesis
on the first line.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help