Thread (4 messages) 4 messages, 2 authors, 2012-10-08

Re: [RFC:PATCH 3.6.0-] net/ipconfig: Extend ipconfig retries to device open

flat view

From: David Miller <davem@davemloft.net>
Date: 2012-10-07 04:12:00

From: Srinivas KANDAGATLA <redacted>
Date: Thu,  4 Oct 2012 16:38:43 +0100
This patch adds retries to ipconfig at device open, the reason to do
this is: Lets say If some mdio bus driver decide to use defered probe
when it does not find any phys on the bus. The same mdio-bus driver is
re-probed as part of lateinit calls. However ipconfig also fits into
lateinit calls, so if ipconfig is called before the re-probe of mdio-bus
driver, the mac driver will fail to find a valid PHY on the mdio-bus.
Real device drivers for real devices should not probe using late
initcalls.

The whole point of late initcalls is that you can be certain that they
run after such things.

Fix the virus not the symptom.

I'm not applying this patch.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help