Re: [RFC] vxlan: use ether header as fallback hash

On Thu, 2012-10-04 at 09:43 -0700, Stephen Hemminger wrote:

On Thu, 4 Oct 2012 09:27:14 -0700
Jesse Gross [off-list ref] wrote:

quoted

quoted

+static u16 vxlan_flow_hash(struct sk_buff *skb)
+{
+       u16 hash = skb_get_rxhash(skb);
+
+       if (!hash)
+               hash = jhash(skb->data, 3, skb->protocol);

Shouldn't this be jhash2 for words?

No. for a couple of reasons. First, the ethernet header may not be aligned.
Second we want to get source/destination and type.  The source/destination
is 12 bytes (3 words) and the ether type is already in skb->protocol.

jhash(skb->data, 12, initval)