Re: [PATCHv2] rtlwifi: rtl8192ce: rtl8192cu: use %*ph[C] to dump small buffers
flat view
From: Joe Perches <joe@perches.com>
Date: 2012-10-01 11:14:56
Also in:
linux-wireless
On Mon, 2012-10-01 at 13:54 +0300, Andy Shevchenko wrote:
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> ACKed-by: Larry Finger <redacted>
Hey Andy. The conversions are not all the same. One uses "%*ph", the others use "%*phC" even though all origin hex formats are "%x:%x:..." Ideally all the conversions would use the same format style.
quoted hunk ↗ jump to hunk
diff --git a/drivers/net/wireless/rtlwifi/cam.c b/drivers/net/wireless/rtlwifi/cam.c
quoted hunk ↗ jump to hunk
@@ -52,11 +52,8 @@ static void rtl_cam_program_entry(struct ieee80211_hw *hw, u32 entry_no,
[]
quoted hunk ↗ jump to hunk
- RT_TRACE(rtlpriv, COMP_SEC, DBG_LOUD, - "key_cont_128:\n %x:%x:%x:%x:%x:%x\n", - key_cont_128[0], key_cont_128[1], - key_cont_128[2], key_cont_128[3], - key_cont_128[4], key_cont_128[5]); + RT_TRACE(rtlpriv, COMP_SEC, DBG_LOUD, "key_cont_128: %*ph\n", + 6, key_cont_128);
Uses "%*ph" You removed a newline. That should probably be mentioned in the changelog. It would be a bit nicer as well to align the arguments after the open paren like: RT_TRACE(rtlpriv, COMP_SEC, DBG_LOUD, "key_cont_128: %*ph\n", 6, key_cont_128);
quoted hunk ↗ jump to hunk
diff --git a/drivers/net/wireless/rtlwifi/rtl8192ce/hw.c b/drivers/net/wireless/rtlwifi/rtl8192ce/hw.c
[]
quoted hunk ↗ jump to hunk
@@ -1918,10 +1918,8 @@ static void rtl92ce_update_hal_rate_mask(struct ieee80211_hw *hw,
[]
quoted hunk ↗ jump to hunk
- "Rate_index:%x, ratr_val:%x, %x:%x:%x:%x:%x\n", - ratr_index, ratr_bitmap, - rate_mask[0], rate_mask[1], rate_mask[2], rate_mask[3], - rate_mask[4]); + "Rate_index:%x, ratr_val:%x, %*phC\n", + ratr_index, ratr_bitmap, 5, rate_mask);
Uaes "%*phC", etc...
quoted hunk ↗ jump to hunk
diff --git a/drivers/net/wireless/rtlwifi/rtl8192cu/hw.c b/drivers/net/wireless/rtlwifi/rtl8192cu/hw.c
[]
quoted hunk ↗ jump to hunk
@@ -2169,10 +2169,8 @@ void rtl92cu_update_hal_rate_mask(struct ieee80211_hw *hw, u8 rssi_level)
[]
quoted hunk ↗ jump to hunk
- "Rate_index:%x, ratr_val:%x, %x:%x:%x:%x:%x\n", - ratr_index, ratr_bitmap, - rate_mask[0], rate_mask[1], rate_mask[2], rate_mask[3], - rate_mask[4]); + "Rate_index:%x, ratr_val:%x, %*phC\n", + ratr_index, ratr_bitmap, 5, rate_mask);
here too