Re: [PATCH 02/11] inet_diag: pass inet_diag module to netlink_dump_start

From
Pablo Neira Ayuso <hidden>
Date
2012-09-26 17:26:14
Also in
linux-crypto, linux-rdma, netfilter-devel
On Wed, Sep 26, 2012 at 09:07:14AM -0700, Stephen Hemminger wrote:
On Wed, 26 Sep 2012 12:52:11 +0800
Gao feng [off-list ref] wrote:
quoted
 			struct netlink_dump_control c = {
 				.dump = inet_diag_dump_compat,
+				.done = netlink_dump_done,
+				.module = THIS_MODULE,
 			};
Since these are immutable, why the netlink_dump_control structures
on the stack (which requires code to generate at runtime), and instead
make them global

static const struct netlink_dump_control unix_diag_ctrl = {
...
I made that code. I can send a patch to statify those
netlink_dump_control structures.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Thread (1 message) 1 message, 1 author, 2012-09-26
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help