Re: [PATCH v5 01/10] ipc: remove forced assignment of selected message
flat view
From: Serge Hallyn <hidden>
Date: 2012-09-26 17:37:36
Also in:
lkml
Quoting Stanislav Kinsbursky (skinsbursky@parallels.com):
quoted hunk ↗ jump to hunk
This is a cleanup patch. The assignment is redundant. Signed-off-by: Stanislav Kinsbursky <redacted> --- ipc/msg.c | 1 - 1 files changed, 0 insertions(+), 1 deletions(-)diff --git a/ipc/msg.c b/ipc/msg.c index 7385de2..f3bfbb8 100644 --- a/ipc/msg.c +++ b/ipc/msg.c@@ -787,7 +787,6 @@ long do_msgrcv(int msqid, long *pmtype, void __user *mtext, !security_msg_queue_msgrcv(msq, walk_msg, current, msgtyp, mode)) { - msg = walk_msg; if (mode == SEARCH_LESSEQUAL && walk_msg->m_type != 1) { msg = walk_msg;
Perhaps your tree is different from mine, but it looks to me like it would be simpler to remove the 'msg = walk_msg' from both the 'if' and 'else', and keep them above the if/else?