Re: [PATCH 9/9] drivers/isdn/gigaset/common.c: Remove useless kfree
From: Tilman Schmidt <hidden>
Date: 2012-09-13 09:52:44
Also in:
kernel-janitors, lkml
Am 12.09.2012 17:06, schrieb Peter Senna Tschudin:
From: Peter Senna Tschudin <peter.senna@gmail.com> Remove useless kfree() and clean up code related to the removal. The semantic patch that finds this problem is as follows:
[...]
Signed-off-by: Peter Senna Tschudin <peter.senna@gmail.com>
Acked-by: Tilman Schmidt <redacted>
quoted hunk ↗ jump to hunk
--- drivers/isdn/gigaset/common.c | 1 - 1 file changed, 1 deletion(-)diff --git a/drivers/isdn/gigaset/common.c b/drivers/isdn/gigaset/common.c index aa41485..30a6b17 100644 --- a/drivers/isdn/gigaset/common.c +++ b/drivers/isdn/gigaset/common.c@@ -1123,7 +1123,6 @@ struct gigaset_driver *gigaset_initdriver(unsigned minor, unsigned minors, return drv; error: - kfree(drv->cs); kfree(drv); return NULL; }
This is indeed vestigial code, left in when another error path that needed it was removed. Though innocuous, it's better to remove it. Thanks, Tilman -- Tilman Schmidt E-Mail: tilman@imap.cc Bonn, Germany Diese Nachricht besteht zu 100% aus wiederverwerteten Bits. Ungeöffnet mindestens haltbar bis: (siehe Rückseite)
Attachments
- signature.asc [application/pgp-signature] 260 bytes