Thread (11 messages) 11 messages, 3 authors, 2012-09-28

Re: [PATCH 7/7 net-next] tg3: Change default number of tx rings to 1.

From: David Miller <davem@davemloft.net>
Date: 2012-09-27 23:23:46

From: "Michael Chan" <mchan@broadcom.com>
Date: Wed, 26 Sep 2012 15:32:49 -0700
Hardware tx scheduling can cause some starvation of a tx ring with small
packets if other tx rings have jumbo or TSO packets.  The default setting
of 1 TX ring gives the best overall performance in many common traffic
scenarios.  The user can change it using ethttol -L if desired.

Update version to 3.125.

Reviewed-by: Nithin Nayak Sujir <redacted>
Reviewed-by: Benjamin Li <redacted>
Signed-off-by: Michael Chan <mchan@broadcom.com>
This gets into an area I don't like.

Individual drivers making decisions about defaults that sound like
system wide ones.

What makes tg3 so special that only it should have this default
setting?

I also can't see how this "one guy spamming small packets while
another generates TSO frames" completely nullifies the SMP gains
from using multiple TX rings and distributing traffic.

I'm not applying this patch set.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help