Re: [PATCH net-next] filter: add XOR instruction for use with X/K

David Miller [off-list ref] [2012-09-24 16:50:05 -0400] wrote:

From: Eric Dumazet <redacted>
Date: Mon, 24 Sep 2012 15:43:48 +0200

quoted

On Mon, 2012-09-24 at 14:23 +0200, Daniel Borkmann wrote:

quoted

BPF_S_ANC_ALU_XOR_X has been added a while ago, but as an 'ancillary'
operation that is invoked through a negative offset in K within BPF
load operations. Since BPF_MOD has recently been added, BPF_XOR should
also be part of the common ALU operations. Removing BPF_S_ANC_ALU_XOR_X
might not be an option since this is exposed to user space.

Please note we dont expose BPF_S_ANC_ALU_XOR_X to user space.

We expose SKF_AD_ALU_XOR_X instead.

But it seems easier to leave it to keep this patch small (not touching
various JIT implementations, even if followup are welcomed)

Acked-by: Eric Dumazet <edumazet@google.com>

I applied this, fixing the commit message to refer to SKF_AD_ALU_XOR_X
instead of BPF_S_ANC_ALU_XOR_X.

Thanks David!