Re: [RFC PATCHv2 bridge 7/7] bridge: Add the ability to show dump the vlan map from a bridge port

On Mon, 2012-09-24 at 09:49 -0400, Vlad Yasevich wrote:

On 09/22/2012 04:05 PM, Stephen Hemminger wrote:

quoted

On Sat, 22 Sep 2012 13:27:47 -0400 (EDT)
David Miller [off-list ref] wrote:

quoted

From: Ben Hutchings <redacted>
Date: Sat, 22 Sep 2012 18:15:32 +0100

quoted

On Wed, 2012-09-19 at 08:42 -0400, Vlad Yasevich wrote:

quoted

Using the RTM_GETLINK dump the vlan map of a given bridge port.

[...]

This enlarges the RTM_GETLINK response quite a bit.  I think perhaps
this should be optional, like IFLA_VFINFO_LIST is now.

Completely agreed.

Since most users won't use it, it should be not necessary to include
it if the map is blank.

Response is included only for AF_BRIDGE calls (proably used by STP 
implementation) and only when vlan filtering is configured.

I do see the point though and can add a filter for this.

I thought the per-AF stuff was included by default (or at least what
most clients ask for).  If not then this is probably fine.
IFLA_VFINFO_LIST was causing glibc's queries to fail and that must be
avoided.

Ben.

-- 
Ben Hutchings, Staff Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.