Thread (3 messages) flat view 3 messages, 2 authors, 2012-09-24

Re: [PATCH net-next] gianfar: Change default HW Tx queue scheduling mode

From: Claudiu Manoil <hidden>
Date: 2012-09-24 10:46:55

On 09/21/2012 08:35 PM, David Miller wrote:
From: Claudiu Manoil <redacted>
Date: Thu, 20 Sep 2012 18:57:54 +0300
quoted
The TXSCHED setting may be changed at runtime, via sysfs, for devices
using multiple H/W Tx queues. For single queue devices this config
option is disabled, as the TXSCHED setting is superfluous in those cases.
Please, no special driver specific sysfs knobs.

Extend ethtool as necessary for your needs, so that any driver can
provide this kind of configurability in a consistent way for users..
Ok.
Resent the patch addressing the watchdog timeout issue, without the 
runtime configuration part.
(see http://patchwork.ozlabs.org/patch/186315/).
This config option seems to be better off in a separate patch, 
especially if it would imply changes to ethtool.
What would you think of such an ethtool extension? Beside allowing the 
user to choose b/w letting the H/W to service its Tx queues equally or 
according to a built-in priority scheme, it could also provide api to 
configure scheduling weights per Tx queue for a weighted round-robin 
queue selection scheme, or, to configure only a single weight for all 
the queues (for a balanced scheme). (Are there currently other drivers/ 
devices that would use such an option?)

Thanks,
Claudiu
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help