Re: [PATCH 1/3 V2] phy/micrel: Implement support for KSZ8021

Dear David Miller,

From: Marek Vasut <marex@denx.de>
Date: Fri, 21 Sep 2012 04:52:54 +0200

quoted

+	phy_write(phydev, MII_KSZPHY_OMSO,
+		KSZPHY_OMSO_B_CAST_OFF | KSZPHY_OMSO_RMII_OVERRIDE);

This is not indented properly.  The goal is not to exclusively use
TAB characters to indent code until it sort-of looks fine.

The goal was to avoid checkpatch trouble.

Rather, the goal is to properly line up function arguments with
the first column after the openning parenthesis on the previous
line.  Using TAB and SPACE characters, as needed.

quoted

+	.features	= (PHY_BASIC_FEATURES | SUPPORTED_Pause
+				| SUPPORTED_Asym_Pause),

This is similarly not styled properly.

This is copy-pasted from other entry. I'd hate to reformat the whole file.

Besies being indented imporperly on the second line, the final "|"
character should be at the end of the first line, rather than
start the second line.

DTTO here.

Resubmit this entire patch series, not just this one patch, once
you've made these corrections.

Thanks.

Best regards,
Marek Vasut