RE: [PATCH net-next 3/3] ptp: derive the device name from the parent device

On Fri, 2012-09-21 at 17:39 +0000, Keller, Jacob E wrote:

quoted

-----Original Message-----
From: Richard Cochran [mailto:richardcochran@gmail.com]
Sent: Friday, September 21, 2012 10:37 AM
To: Ben Hutchings
Cc: netdev@vger.kernel.org; David Miller; Keller, Jacob E; Kirsher,
Jeffrey T; John Stultz; Vick, Matthew
Subject: Re: [PATCH net-next 3/3] ptp: derive the device name from the
parent device

On Fri, Sep 21, 2012 at 06:19:25PM +0100, Ben Hutchings wrote:

quoted

On Fri, 2012-09-21 at 19:00 +0200, Richard Cochran wrote:

quoted

PTP Hardware Clock device have a name that appears under sysfs that
should identify the underlying device. Instead of leaving it up to
the driver to invent a name, this patch changes the registration to
automatically use the name from the parent device.

I thought you wanted the driver name and not the parent device name?

Yes, I originally wanted the driver name, because it gives the user
information about the expected performance. But here I am bowing to
Jacob's suggestion that we really need to identify the device. Intel cards
with two ports have *two* clocks. Sad but true.

With the device, it is possible to lookup the driver.

For PCI devices, yes.  But there is really no guarantee that device
names (as in dev_name()) are globally unique either.

Ben.

-- 
Ben Hutchings, Staff Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.