[PATCH v1 0/19] qlcnic: patches for new adapter - Qlogic 83XX CNA · Sony Chacko <hidden> · 2012-09-20
[PATCH v1 19/19] qlcnic: update driver version - 5.1.30 · Sony Chacko <hidden> · 2012-09-20
[PATCH v1 11/19] qlcnic: sysfs interface routine updates · Sony Chacko <hidden> · 2012-09-20
Re: [PATCH v1 11/19] qlcnic: sysfs interface routine updates · David Miller <davem@davemloft.net> · 2012-09-20
[PATCH v1 16/19] qlcnic: enable 83xx virtual NIC mode · Sony Chacko <hidden> · 2012-09-20
[PATCH v1 13/19] qlcnic: 83xx hardware access and data path routines · Sony Chacko <hidden> · 2012-09-20
Re: [PATCH v1 13/19] qlcnic: 83xx hardware access and data path routines · David Miller <davem@davemloft.net> · 2012-09-20
[PATCH v1 17/19] qlcnic: common register dump utility · Sony Chacko <hidden> · 2012-09-20
[PATCH v1 07/19] qlcnic: get board name API · Sony Chacko <hidden> · 2012-09-20
[PATCH v1 10/19] qlcnic: rename module params with module_param_named · Sony Chacko <hidden> · 2012-09-20
[PATCH v1 18/19] qlcnic: 83xx adpater ethtool · Sony Chacko <hidden> · 2012-09-20
[PATCH v1 08/19] qlcnic: update NIC partition interface routines · Sony Chacko <hidden> · 2012-09-20
[PATCH v1 09/19] qlcnic: cleanup unused register interfaces · Sony Chacko <hidden> · 2012-09-20
[PATCH v1 12/19] qlcnic: update irq management routines · Sony Chacko <hidden> · 2012-09-20
Re: [PATCH v1 12/19] qlcnic: update irq management routines · David Miller <davem@davemloft.net> · 2012-09-20
[PATCH v1 04/19] qlcnic: change IO and PCI register acccess routines · Sony Chacko <hidden> · 2012-09-20
[PATCH v1 01/19] qlcnic: remove 82xx specific register dump utility · Sony Chacko <hidden> · 2012-09-20
[PATCH v1 03/19] qlcnic: create seperate file for data path routines · Sony Chacko <hidden> · 2012-09-20
[PATCH v1 14/19] qlcnic: 83xx adpater flash interface routines · Sony Chacko <hidden> · 2012-09-20
[PATCH v1 02/19] qlcnic: move HW specific data to seperate structure · Sony Chacko <hidden> · 2012-09-20
[PATCH v1 06/19] qlcnic: driver resource allocation · Sony Chacko <hidden> · 2012-09-20
[PATCH v1 15/19] qlcnic: 83xx CNA inter driver communication mechanism · Sony Chacko <hidden> · 2012-09-20
[PATCH v1 05/19] qlcnic: change driver hardware interface mechanism · Sony Chacko <hidden> · 2012-09-20
Re: [PATCH v1 05/19] qlcnic: change driver hardware interface mechanism · David Miller <davem@davemloft.net> · 2012-09-20
Re: [PATCH v1 0/19] qlcnic: patches for new adapter - Qlogic 83XX CNA · David Miller <davem@davemloft.net> · 2012-09-20

Re: [PATCH v1 0/19] qlcnic: patches for new adapter - Qlogic 83XX CNA

From: David Miller <davem@davemloft.net>
Date: 2012-09-20 22:47:02

I tired reviewing this driver just for coding style issues after just
looking at two or three of them.

I hope that it is no surprise to you that people are very reluctant to
review this driver at all, given how much basic stylistic issues
remain.

I haven't even begun to think about the actual technical semantics and
correctness of these patches.  I doubt anyone else in the community
had either, and that won't even begin to happen until the coding style
issues are rectified.

You guys have a long, very long, way to go with this patch set.

`h`	back out one level
`j`	next message in thread
`k`	previous message in thread
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help