RE: [PATCH net-next] mlx4: use dev_kfree_skb() instead of dev_kfree_skb_any()

From
Yevgeny Petrilin <hidden>
Date
2012-09-19 07:59:36
Reply to
Eric Dumazet, 2012-09-17
Since commit e22979d96a5 (mlx4_en: Moving to Interrupts for TX
completions), we no longer can free TX skb from hard IRQ, but only from
normal softirq or process context.

Therefore, we can directly call dev_kfree_skb() from
mlx4_en_free_tx_desc() like other conventional NAPI drivers.
Hi Eric,
At the moment the TX completion processing is done from IRQ context.
So I think we need to change the driver to work with NAPI for TX completions
before making this change.

I'll send the patch in a few days.

Yevgeny
Thread (10 messages) 10 messages, 5 authors, last reply 2012-10-01
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help