Thread (18 messages) flat view 18 messages, 8 authors, 2012-09-18

Re: [net] e1000: Small packets may get corrupted during padding by HW

From: Alexander Duyck <hidden>
Date: 2012-09-18 05:55:54

On 9/17/2012 10:45 PM, Eric Dumazet wrote:
On Mon, 2012-09-17 at 20:27 -0700, Alexander Duyck wrote:
quoted
It also just occurred to me that there might be some benefit in cache
aligning the max header size.  It seems like doing something like that
should reduce the overall memory footprint and would probably improve
performance.
Given that most ACK packets are 66 bytes (14 ethernet + 20 IP + 32 TCP),
I am not sure we need to make any tweak on alignment ?
I'm honestly not sure myself.  I will probably spend a few hours 
tomorrow tweaking a few things to test and see if there is any gain to 
be had there.  The only reason why it occurred to me is that it really 
isn't too far off from what we did back on the Rx side, except for there 
we were aligning at the start of the buffer and working our way up.

Thanks,

Alex
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help