Thread (6 messages) flat view 6 messages, 2 authors, 2012-09-11

Re: [PATCH v2 2/2] iproute2: use libgenl in ipl2tp

From: Julian Anastasov <ja@ssi.bg>
Date: 2012-09-11 20:18:49

	Hello,

On Tue, 11 Sep 2012, Stephen Hemminger wrote:
On Tue, 11 Sep 2012 12:04:34 +0300
Julian Anastasov [off-list ref] wrote:
quoted
	Use the common code from libgenl.c to parse family.

Signed-off-by: Julian Anastasov <ja@ssi.bg>
I applied these two but made some modifications:
  1. change to GENL_INITIALIZER
  2. use GENL_INITIALIZER
	I used 2 defines, so that in tcp_metrics.c I can
use different initialization depending on the command.
But as the structure is unnamed may be it is better to have
single define (both defines merged as you proposed) and
later just to update cmd and flags if needed.

Regards

--
Julian Anastasov [off-list ref]
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help