Re: [PATCH net-next 0/12] qlcnic: patches for new adapter - Qlogic 83XX CNA
From: David Miller <davem@davemloft.net>
Date: 2012-09-01 00:53:09
From: David Miller <davem@davemloft.net>
Date: 2012-09-01 00:53:09
From: David Miller <davem@davemloft.net> Date: Fri, 31 Aug 2012 20:00:35 -0400 (EDT)
From: Sony Chacko <redacted> Date: Fri, 31 Aug 2012 18:36:47 -0400quoted
Please apply the updated patch series to net-next.You posted too soon, you received other feedback in the mean-time which you should address as well.
Also in patch #5: - qlcnic_config_ipaddr(adapter, ifa->ifa_address, QLCNIC_IP_UP); + qlcnic_config_ipaddr(adapter, ifa->ifa_address, + QLCNIC_IP_UP); This is not the correct way to format multi-line function calls, the correct way is: qlcnic_config_ipaddr(adapter, ifa->ifa_address, QLCNIC_IP_UP); That is, you line up the first character of the argument to the column right after the openning parenthesis on the pevious line, using the appropriate number of TAB and SPACE characters necessary to achieve that.