Re: [PATCH 7/7] net/netfilter/nf_conntrack_netlink.c: fix error return code

On Wed, Aug 29, 2012 at 06:49:16PM +0200, Julia Lawall wrote:

From: Julia Lawall <redacted>

Initialize return variable before exiting on an error path.

A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/)

// <smpl>
(
if@p1 (\(ret < 0\|ret != 0\))
 { ... return ret; }
|
ret@p1 = 0
)
... when != ret = e1
    when != &ret
*if(...)
{
  ... when != ret = e2
      when forall
 return ret;
}

// </smpl>

Applied, thanks.