Re: [PATCH 6/7] net/netfilter/nfnetlink_log.c: fix error return code

From
Pablo Neira Ayuso <pablo@netfilter.org>
Date
2012-08-30 01:36:00
Also in
kernel-janitors, lkml, netfilter-devel
Reply to
Julia Lawall, 2012-08-29
On Wed, Aug 29, 2012 at 06:49:17PM +0200, Julia Lawall wrote:
From: Julia Lawall <redacted>

Initialize return variable before exiting on an error path.

A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/)

// <smpl>
(
if@p1 (\(ret < 0\|ret != 0\))
 { ... return ret; }
|
ret@p1 = 0
)
... when != ret = e1
    when != &ret
*if(...)
{
  ... when != ret = e2
      when forall
 return ret;
}

// </smpl>
And also applied, thanks Julia. I'll pass these to current -rc.
Thread (2 messages) 2 messages, 2 authors, 2012-08-30
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help